Skip to content

[Payment due @thelullabyy] Vendor matching CC: Add Vendors tab to Workspace settings#96143

Merged
marcochavezf merged 31 commits into
mainfrom
beaman-vendors-tab
Jul 20, 2026
Merged

[Payment due @thelullabyy] Vendor matching CC: Add Vendors tab to Workspace settings#96143
marcochavezf merged 31 commits into
mainfrom
beaman-vendors-tab

Conversation

@Beamanator

@Beamanator Beamanator commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds a read-only Vendors tab under Workspace settings for workspaces on the vendorMatching beta with either QBO (Credit/Debit-card export) or Sage Intacct (Credit Card Charge export) connected. The list is sourced from the same Onyx data already used by the vendor selector RHP shipped in App #91886, so this change is App-only — no backend work is required. The tab shows one column (vendor name); the GL code column for QBO is a follow-up that also needs a Java AcctNum fetch in QuickbooksOnlineImporter.java — tracked in the same Expensify #650595 as Phase 2. Intacct never has a GL code so it is fully complete under Phase 1.

The visibility gate is canReadPolicyFeature(POLICY_FEATURE.VENDORS) && hasVendorFeature(policy, isBetaEnabled(BETAS.VENDOR_MATCHING)) && isMatchingVendorListLoaded(policy). The role check reuses ROLE_PERMISSION_BUNDLES in PolicyUtils.ts, which derives the ADMIN/AUDITOR bundles from Object.values(CONST.POLICY.POLICY_FEATURE) — adding POLICY_FEATURE.VENDORS gives admins WRITE and auditors READ automatically, no server-side change required. The list-loaded clause is stricter than the inline surfaces (Default vendor row, per-expense Vendor field) because a read-only externally-synced destination with no user CTA reads as broken if it opens empty; the page still ships a belt-and-braces empty state for the edge case where the tab is reached before the list populates.

For non-active workspaces the effect that triggers openPolicyAccountingPage runs in WorkspaceInitialPage, gated on the same read-access check, and the page itself is wrapped in withPolicyConnections so direct-URL access hydrates connections before evaluating the wrapper. Offline and Onyx-hydration-race cases are handled by mirroring withPolicyConnections's isOffline and isLoadingOnyxValue guards.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/650595

PROPOSAL: N/A (internal feature, no external proposal)

Tests

Prerequisites: a workspace with the vendorMatching beta enabled and either (a) QBO connected with non-reimbursable export destination set to Credit Card or Debit Card, or (b) Sage Intacct connected with Credit Card Charge export.

Happy path

  1. Wait for the initial accounting sync to complete on the test workspace.
  2. Open Settings → Workspaces → the test workspace.
  3. Verify a new Vendors row appears in the workspace navigation (below Categories, above Tags when both are enabled).
  4. Tap the row and verify the Vendors page opens.
  5. Verify the vendor list matches the imported vendor list from the connected accounting system (spot-check three names).
  6. Verify each row has no radio/checkbox — the list is read-only.
  7. Type into the search box and verify the list filters case-insensitively as you type.
  8. Clear the search and verify the full list returns.

Visibility branches

  1. Flip the workspace's non-reimbursable export type to Vendor Bill: for QBO via Workspace → Accounting → QuickBooks Online → Export → Company card expenses, for Intacct via Workspace → Accounting → Sage Intacct → Export → Non-reimbursable expenses. Return to Workspace settings and verify the Vendors row disappears.
  2. Flip the export type back (QBO: Credit Card or Debit Card; Intacct: Credit Card Charge) and verify the row reappears.
  3. Disable the vendorMatching beta for the test user and verify the Vendors row is hidden regardless of export type.

Role-based access (Control workspace)

  1. Add an Auditor to the Control workspace. Log in as the Auditor and verify the Vendors row is visible and the list renders. POLICY.POLICY_FEATURE.VENDORS auto-picks up READ for Auditors via ROLE_PERMISSION_BUNDLES in PolicyUtils.ts.
  2. Add a Card Admin to the same workspace. Log in as the Card Admin and verify the Vendors row is hidden (Card Admins can reach workspace settings via Expensify Card / Company Cards but do not have VENDORS in their permission bundle).

Edge cases

  1. On a workspace that just enabled the beta but where the initial accounting sync hasn't yet completed: open Workspace settings and verify the Vendors row is hidden (the isMatchingVendorListLoaded clause of the gate). After the sync completes, the row appears.
  2. On a workspace you have not previously visited (so policy.connections isn't hydrated on app start): paste /workspaces/<policyID>/vendors directly into the URL bar. Verify the page shows a loading indicator until withPolicyConnections hydrates the connections, then renders the list.
  • Verify that no errors appear in the JS console

Offline tests

  1. Complete steps 1–4 of the Tests section online, then disable your network connection.
  2. Verify the Vendors page still opens from cached Onyx state and the vendor list renders as it did online.
  3. Verify the search box continues to filter the cached list.
  4. Reconnect coverage: on a different workspace you have not visited (so policy.connections isn't hydrated), keep the network disabled and open Workspace settings; verify the Vendors row is hidden. Re-enable the network and verify the row appears without requiring a manual navigation to Accounting — the effect refires on the isOffline transition.
  • Verify that no errors appear in the JS console

QA Steps

Ping me & @heyjennahay to test!

Same as Tests - Note: tester must have the vendorMatching beta enabled

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English.
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function
  • If new assets were added or existing ones were modified
  • If the PR modifies code that runs when editing or sending messages
  • If the PR modifies a generic component
  • If the PR modifies a component related to any of the existing Storybook stories
  • If the PR modifies a component or page that can be accessed by a direct deeplink
  • If the PR modifies the UI or modifies the form input styles
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2026-07-16 at 4 02 56 PM Screenshot 2026-07-16 at 4 02 51 PM

Adds a read-only Vendors tab to Workspace settings for workspaces with the
`vendorMatching` beta enabled and either QBO (Credit/Debit-card export) or
Sage Intacct (Credit Card Charge export) connected. Sourced from the
existing `connections.<name>.data.vendors` Onyx data used by the vendor
selector RHP shipped in #91886, so no backend changes are required.

Gate: `hasVendorFeature(policy, isBetaEnabled(BETAS.VENDOR_MATCHING)) &&
isMatchingVendorListLoaded(policy)`. The list-loaded clause is stricter
than the inline surfaces (Default vendor row, per-expense Vendor field)
because a read-only externally-synced list with no user CTA is a dead end
if it opens empty.

Phase 2 (GL code column for QBO) requires a Java `AcctNum` fetch in
`QuickbooksOnlineImporter.java` and follows in a separate change. Intacct
is fully complete under Phase 1 (no GL code in Intacct vendor imports).

See Expensify/Expensify#650595 for the full plan.
@Beamanator
Beamanator requested review from a team as code owners July 14, 2026 22:54
@melvin-bot
melvin-bot Bot requested review from Krishna2323 and removed request for a team July 14, 2026 22:54
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team July 14, 2026 22:54
@OSBotify

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79c5adcdb4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/WorkspaceInitialPage.tsx Outdated
Comment thread src/pages/workspace/vendors/WorkspaceVendorsPage.tsx Outdated
- Gate the Vendors menu row on isPolicyAdmin(policy) so it mirrors the
  page's [ADMIN, PAID] accessVariants. Without this, non-admin members
  saw the menu row but tap-through rendered NotFound.
- Add SCREENS.WORKSPACE.VENDORS to WIDE_LAYOUT_INACTIVE_SCREENS so the
  keyboard focus trap is disabled on wide side-by-side layouts, matching
  every other workspace central-pane screen.
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.81% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
...mponents/FocusTrap/WIDE_LAYOUT_INACTIVE_SCREENS.ts 0.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 66.66% <ø> (ø)
src/pages/workspace/withPolicy.tsx 95.00% <ø> (ø)
...ppNavigator/Navigators/WorkspaceSplitNavigator.tsx 8.57% <0.00%> (-0.26%) ⬇️
src/pages/workspace/withPolicyConnections.tsx 0.00% <0.00%> (ø)
src/ROUTES.ts 21.48% <0.00%> (-0.08%) ⬇️
src/pages/workspace/WorkspaceInitialPage.tsx 0.00% <0.00%> (ø)
... and 4 more
... and 17 files with indirect coverage changes

@Beamanator

Copy link
Copy Markdown
Contributor Author

@codex review

@Krishna2323

Copy link
Copy Markdown
Contributor

@Beamanator does this require C+ review?

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6a5d12c05

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/WorkspaceInitialPage.tsx Outdated
Comment thread src/pages/workspace/vendors/WorkspaceVendorsPage.tsx Outdated
- Fix isMatchingVendorListLoaded so it returns false for Intacct workspaces
  that haven't synced yet. Previously the Intacct branch of
  getActiveVendorMatchingVendors normalized a missing data.vendors to [],
  which meant the helper returned an array (not undefined) and the tab
  gate opened onto an empty page — the exact pre-sync state we're trying
  to avoid. QBO was already correct because it returned data?.vendors
  directly.
- Set shouldHideSelectionButton on the Vendors page rows so
  SelectableListItem skips the radio button. The list is read-only, so
  showing radio buttons with a no-op onSelectRow made rows look like
  editable pickers with no feedback on tap.
@Beamanator

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d184b98dd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/WorkspaceInitialPage.tsx Outdated
@Beamanator

Copy link
Copy Markdown
Contributor Author

@Krishna2323 hey hey! I think yes, do you have experience with setting up QBO / other accounting integrations? If so, can you let me know an email address you have for testing this so i can add it to the beta for you to test? 🙏

If not, no worries i can find someone else to help test this!

Only the active policy has connections data at app start (per
withPolicyConnections's own docstring); other workspaces have to fetch
it lazily. hasVendorFeature() and isMatchingVendorListLoaded() both
read `policy.connections`, so on a non-active vendor-matching workspace
the Vendors menu row was staying hidden even after the beta was flipped
on, until the user visited the Accounting tab.

Add an effect that mirrors withPolicyConnections' fetch trigger inline
in WorkspaceInitialPage, gated on the VENDOR_MATCHING beta so we don't
add an accounting-page fetch to every workspace visit for non-beta
users. Same self-gates as withPolicyConnections: bails if connections
are already fetched, or if the workspace has no connections enabled at
all.
@Beamanator

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de45732ec3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/vendors/WorkspaceVendorsPage.tsx
The previous commit added a connections-prefetch effect to
WorkspaceInitialPage so the sidebar tab renders on non-active workspaces,
but that only covers the sidebar entry point. A user opening or
refreshing /workspaces/:policyID/vendors directly on a non-active
workspace still hit the page before connections were fetched, so
hasVendorFeature() returned false and AccessOrNotFoundWrapper rendered
NotFound.

Wrap WorkspaceVendorsPage in withPolicyConnections so the page itself
triggers the fetch and shows a loading indicator until connections are
available. Also register VENDORS in the PolicyRouteName union used by
withPolicy's route type, matching how CATEGORIES/TAGS/etc. are typed.
@Beamanator

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9f0095593

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/WorkspaceInitialPage.tsx Outdated
useOnyx returns undefined for the value during initial hydration, so my
guard on !hasConnectionsDataBeenFetched passed even when the persisted
flag was actually true, causing a redundant openPolicyAccountingPage
call on every workspace-page rehydrate. Mirror withPolicyConnections
by reading the second-tuple result metadata and gating on
isLoadingOnyxValue.
@Beamanator

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ab6b5b010

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/WorkspaceInitialPage.tsx Outdated
- usePolicyConnectionsPrefetch: drop the specific caller reference
  (WorkspaceInitialPage was named as an example) so the doc doesn't
  drift as consumers change. Focus on what the hook does and its safety
  guards.
- WorkspaceInitialPage: trim the multi-clause explanation into a shorter
  block that names the read-through it protects against without
  narrating the hypothetical failure mode.
Auto-generated refinements from OSBotify in
#96143 (comment).
Covers de, es, it, ja, nl, pl, pt-BR, zh-hans. Notable fixes:
- de: 'Anbieter/Lieferanten' consistency + preposition fixes
- ja: 'ベンダー' -> '取引先' where more natural for business context
- zh-hans: preposition tweak on managedInAccountingSoftware
…ent fix

Hook subscribed under `..._undefined` when policy was still hydrating.
Fall back to a stable empty-string key and treat the loading flag as
false in that state so we don't gate off a real fetch on the first real
policy render.

Also fix the WorkspaceInitialPage comment: Accounting isn't the only
page that triggers withPolicyConnections' fetch — any wrapped page does.
@Beamanator

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f86474c85

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/vendors/WorkspaceVendorsPage.tsx Outdated
WorkspaceVendorsPage sourced the 'managed in' subtitle from
getConnectedIntegration/getCurrentConnectionName, which pick the first
accounting connection in ACCOUNTING_CONNECTION_NAMES. When Sage Intacct
is the active vendor-matching source but a stale QBO/Xero connection
object is still attached, the header rendered the wrong integration
while the rows below came from Intacct.

New getActiveVendorMatchingIntegration helper (sibling of
getActiveVendorMatchingVendors) returns the connection whose export
mode is actually scoping vendor matching. Page uses it for both the
icon and the display name so the header and rows can't drift.
@Beamanator

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 8289568542

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

rulesdir/no-default-id-values forbids '' fallbacks in Onyx keys. The
shared helper returns undefined when the ID is empty, which useOnyx
treats as 'skip subscription' — same intent as the empty-string
placeholder but conforming to the style guide.
@Beamanator

Copy link
Copy Markdown
Contributor Author

Back to you again @thelullabyy 🙏

@thelullabyy thelullabyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from marcochavezf July 20, 2026 19:04
@melvin-bot

melvin-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot changed the title Vendor matching CC: Add Vendors tab to Workspace settings [Payment due @thelullabyy] Vendor matching CC: Add Vendors tab to Workspace settings Jul 20, 2026
@melvin-bot

melvin-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

🎯 @thelullabyy, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/650595.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@marcochavezf marcochavezf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcochavezf
marcochavezf merged commit e7991d5 into main Jul 20, 2026
45 checks passed
@marcochavezf
marcochavezf deleted the beaman-vendors-tab branch July 20, 2026 21:04
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required (yet)

I reviewed this PR against the help site articles in docs/articles. No help site changes are required at this time, so I did not open a docs PR.

Why:

  • The new Vendors tab is gated behind the vendorMatching beta (canReadPolicyFeature(POLICY_FEATURE.VENDORS) && hasVendorFeature(policy, isBetaEnabled(BETAS.VENDOR_MATCHING)) && isMatchingVendorListLoaded(policy)). The help site documents generally-available behavior — documenting a beta-only surface would surface a feature to the ~99% of readers who can't see it and would need to be revised again at GA.
  • The tab is read-only and self-describing: vendors are pulled from the connected accounting system, and the page itself tells the user where they're managed ("Vendors are managed in your …") plus an empty state ("Vendors will appear here after your accounting sync completes."). There's no user action to document (no create/edit/delete flow), so there's no procedural gap in the existing New Expensify workspace docs.
  • Existing New Expensify workspace feature docs (Create-expense-categories.md, Create-and-manage-expense-tags.md, etc.) each document a feature users configure. A read-only mirror of an external system doesn't fit that pattern until it's GA and there's a user-facing workflow to describe.

Recommended follow-up: when vendorMatching graduates from beta (and especially once Phase 2 adds the QBO GL code column per Expensify/Expensify#650595), add a new-expensify/workspaces article documenting the Vendors tab. I'm happy to draft that PR at that point — just re-ping me.

If you'd prefer I create the draft docs PR now anyway (e.g. to stage the article ahead of GA), reply and I'll put one together.


@Beamanator — since no help site PR was created, there's nothing to review yet. If you'd like the article staged now, reply and I'll open a draft PR for you to review and mark Ready for review.

@Beamanator

Copy link
Copy Markdown
Contributor Author

looking good in staging!

@melvin-bot

melvin-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #96708

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.41-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@heyjennahay

heyjennahay commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Tested in staging and it looks great except one correction, the icon in the menu and next to the heading is wrong

image

They should be a brief case not a suitcase

image image image

@heyjennahay

Copy link
Copy Markdown
Contributor

Also noticed that the (locked) Vendor toggle is missing from More features per the design doc https://docs.google.com/document/d/1Q1n6e7-LcXchKidSRtFMbWkLwN8tY5lvShJjg5joRmo/edit?tab=t.0#heading=h.o44xeklr8ms4

image

Mock up
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants